This repository was archived by the owner on May 25, 2022. It is now read-only.
Converts Jpeg to png #218
Merged
Converts Jpeg to png #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharnankani
suggested changes
Sep 9, 2020
There was a problem hiding this comment.
- Could you comment on your code?
- Avoid extra lines.
- Validate your code with PEP8 standards:
Check PEP8 Validation - (Python Enhancement Proposals) set some guidelines while writing your code.
pip install flake8
flake8 file_name.pyThanks,
Tushar Nankani
|
ok, i'll do it |
tusharnankani
suggested changes
Sep 9, 2020
There was a problem hiding this comment.
Hi @AnuragGupta806!
The script works well! 👍🏻
Great thought on creating a GUI! 👏🏻
Could you disable the Convert JPEG to PNG if no file is uploaded? Since it gives this error. Or could you give a pop up: no file is selected?
Let me know if these changes are possible!
|
I added an error message box and commented the code and validated using PEP8, but one error was left, which was length of line >79, i cannot do anything about it |
tusharnankani
approved these changes
Sep 9, 2020
chavarera
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two python scripts , each having different method of changing JPEG to PNG
Fixes #215
Replace
issue_noin the above line, with the issue related to this PR.Type of change
Choosing one or more options from the following as per the nature of your Pull request.
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md)README.md, according to the givenREADME_TEMPLATE.